Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modernize] use-default-member-init #16735

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Oct 8, 2019

Description

run clang-tidy modernize-use-default-member-init check and applied the suggested fixes
run clang-tidy-diff with modernize-use-nullptr check and applied the suggested fixes
run clang-tidy modernize-use-default-member-init check and applied the suggested fixes
run clang-tidy-diff with modernize-use-equals-default check and applied the suggested fixes

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Oct 8, 2019
@Rechi Rechi added this to the Matrix 19.0-alpha 1 milestone Oct 8, 2019
@Rechi Rechi requested review from fritsch and ksooo October 8, 2019 10:13
@Rechi Rechi force-pushed the modernize/use-default-member-init branch from a41b0f9 to d90510d Compare October 11, 2019 11:27
std::vector<GifColor> m_globalPalette;
unsigned char* m_pTemplate;
unsigned char* m_pTemplate = nullptr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also init m_gifFile with a nullptr here (line 113)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the GifHelper constructor.

GifHelper::GifHelper() :
m_imageSize(0),
m_pitch(0),
m_loops(0),
m_numFrames(0),
m_filename(""),
m_gif(nullptr),
m_pTemplate(nullptr)
{
m_gifFile = new CFile();
}

xbmc/AppParamParser.h Outdated Show resolved Hide resolved
xbmc/cores/AudioEngine/Utils/AERingBuffer.h Show resolved Hide resolved
xbmc/input/actions/Action.h Outdated Show resolved Hide resolved
@Rechi Rechi force-pushed the modernize/use-default-member-init branch 2 times, most recently from 6ac6b4e to 8706eb6 Compare October 13, 2019 09:56
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@Rechi Rechi force-pushed the modernize/use-default-member-init branch from 8706eb6 to 114f2be Compare October 13, 2019 14:47
@Rechi Rechi force-pushed the modernize/use-default-member-init branch 2 times, most recently from 2924676 to 44c02d1 Compare January 19, 2020 14:12
@Rechi Rechi force-pushed the modernize/use-default-member-init branch from 44c02d1 to 5366c06 Compare January 19, 2020 20:30
@Rechi Rechi merged commit a66cb5e into xbmc:master Jan 20, 2020
@Rechi Rechi deleted the modernize/use-default-member-init branch January 20, 2020 10:13
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants