-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modernize] use-default-member-init #16735
Conversation
a41b0f9
to
d90510d
Compare
std::vector<GifColor> m_globalPalette; | ||
unsigned char* m_pTemplate; | ||
unsigned char* m_pTemplate = nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also init m_gifFile
with a nullptr here (line 113)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at the GifHelper
constructor.
xbmc/tools/depends/native/TexturePacker/src/decoder/GifHelper.cpp
Lines 46 to 56 in dd178e7
GifHelper::GifHelper() : | |
m_imageSize(0), | |
m_pitch(0), | |
m_loops(0), | |
m_numFrames(0), | |
m_filename(""), | |
m_gif(nullptr), | |
m_pTemplate(nullptr) | |
{ | |
m_gifFile = new CFile(); | |
} |
6ac6b4e
to
8706eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you
8706eb6
to
114f2be
Compare
2924676
to
44c02d1
Compare
44c02d1
to
5366c06
Compare
…-init [modernize] use-default-member-init
Description
run clang-tidy
modernize-use-default-member-init
check and applied the suggested fixesrun clang-tidy-diff with
modernize-use-nullptr
check and applied the suggested fixesrun clang-tidy
modernize-use-default-member-init
check and applied the suggested fixesrun clang-tidy-diff with
modernize-use-equals-default
check and applied the suggested fixesTypes of change
Checklist: