Implement Apple TV Platform #16860

fuzzard · 2019-11-02T20:39:58Z

Description

Implement the AppleTV platform for ATV4/4k

Motivation and Context

Well here we are, years in the making. May as well say thanks to everyone to get it this far, Memphiz, Davilla (Team Mrmc), Sylvain, Kambala, Phunkyfish, Pogar, and anyone else who has helped that ive missed.

Notes:
PR is not in buildable individual commits. We have broken it up like this for, hopefully, for easier review, particularly the non platform code that is touched. Before Merge, the intent is to squash most into a single commit.
Feel free to update Labels as you see relevant.

Todo:
Currently a lot of refactoring work is being done around darwin_embedded platform as a whole. This will obviously bleed into tvos, but will tackle it later. Feel free to comment on any architecture related issues, but keep in mind, that will most likely go on the todo list for now.

How Has This Been Tested?

ATV dev's, and some external users who have helped with testing

Screenshots (if appropriate):

Types of change

Bug fix (non-breaking change which fixes an issue)
Clean up (non-breaking change which removes non-working, unmaintained functionality)
Improvement (non-breaking change which improves existing functionality)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that will cause existing functionality to change)
Cosmetic change (non-breaking change that doesn't touch code)
None of the above (please explain below)

Checklist:

My code follows the Code Guidelines of this project
My change requires a change to the documentation, either Doxygen or wiki
I have updated the documentation accordingly
I have read the Contributing document
I have added tests to cover my change
All new and existing tests passed

Rechi

You are not following the code guidelines.

fuzzard · 2019-11-03T19:52:46Z

Should be better now rechi. The 2 files that don't conform are 3rd party code we use for a gzip library

tools/depends/target/python3/darwin_embedded.patch

Rechi

For the most commits in this PR I don't know what changes to expect as it is the directory path of the changed files.

cmake/platform/darwin_embedded/tvos.cmake

tools/buildsteps/tvos/prepare-xbmc

xbmc/platform/darwin/tvos/Assets.xcassets/Assets.brandassets/Contents.json

xbmc/platform/darwin/tvos/Assets.xcassets/Assets.brandassets/topshelf.imageset/Contents.json

xbmc/settings/DisplaySettings.cpp

xbmc/platform/darwin/ios-common/DarwinNSUserDefaults.h

xbmc/platform/darwin/ios-common/DarwinNSUserDefaults.mm

Rechi · 2019-11-04T10:42:35Z

cmake/scripts/darwin_embedded/Install.cmake

+# Create xcode target that allows to build binary-addons.
+if(CORE_PLATFORM_NAME_LC STREQUAL tvos)
+  if(ADDONS_TO_BUILD)
+    set(_addons "ADDONS=${ADDONS_TO_BUILD}")
+  endif()
+  add_custom_target(binary-addons
+    COMMAND $(MAKE) -C ${CMAKE_SOURCE_DIR}/tools/depends/target/binary-addons clean
+    COMMAND $(MAKE) -C ${CMAKE_SOURCE_DIR}/tools/depends/target/binary-addons VERBOSE=1 V=99
+          INSTALL_PREFIX="${CMAKE_BINARY_DIR}/addons" CROSS_COMPILING=yes ${_addons})
+  if(ENABLE_XCODE_ADDONBUILD)
+    add_dependencies(${APP_NAME_LC} binary-addons)
+  endif()
+  unset(_addons)
+endif()


Why only add this for tvOS?

Was put in the cmakebuildsys PR earlier, but was asked to be pulled out for "discussion".
Because of timelines, i felt it easier to attribute to tvos only, and if its desired for ios, i can remove the platform check at a later date.

It wasn't related to the previous PR and still isn't to this one. If you want this feature, open a separate PR, which implements it for all platforms.

Its a feature to ease building for the apple tv platform, how is that not relevant here? Just because it could be used for ios is not the point. We are working towards updating ios stuff as well, and thats all still to come, why not add a feature for THIS platform now?

It's not a feature for tvOS only and also not for tvOS and iOS only, it is a general feature.
The reason I ask for doing it right from the beginning is, that otherwise it might get left behind.

Honestly i dont have time to vet it for macos right now. I know it works for ios, but again, i PR'd this early knowing there would be feedback, and i understand where you are coming from regarding "forgotten" catch up features for other platforms, but the point is to get this in for Alpha no? Not everything will be perfect, and theres plenty of todo's.

I would rather put it through in its known tested state, and when time permits and proper testing is done, open up the platform check to others.

fuzzard · 2019-11-04T21:46:02Z

For the most commits in this PR I don't know what changes to expect as it is the directory path of the changed files.

Not sure what you mean by this? is this for the cmake treedata split for tvos/ios

Rechi · 2019-11-05T08:54:29Z

E.g. the commit message [tvOS] system, [tvOS] xbmc or [tvOS] xbmc/addons. I have no idea what it changes, without looking at it.
Actually I see no reason to split the changes for tvOS per xbmc subdirectory, because they do not work / compile stand-alone.

fuzzard · 2019-11-05T08:56:33Z

Notes:
PR is not in buildable individual commits. We have broken it up like this for, hopefully, for easier review, particularly the non platform code that is touched. Before Merge, the intent is to squash most into a single commit.

Thats a quote from the PR message. The intent is for reviewers to see non platform code at a glance for reviewers relevant areas of expertise. It will not merge with this many commits, it WILL be squashed. If you want it squashed now, thats fine by me, it will be a 3 commits.

fuzzard · 2020-01-05T20:37:38Z

Jenkins build this please

fuzzard · 2020-01-06T03:37:17Z

jenkins build this please

fuzzard · 2020-01-06T19:29:16Z

Jenkins build this please

fuzzard · 2020-01-07T04:15:24Z

Jenkins build this please

fuzzard · 2020-01-07T21:01:46Z

Jenkins build this please

fuzzard · 2020-01-08T09:05:41Z

Jenkins build this please

implement WIN_SYSTEM_CLASS define to refactor SettingOptionsMonitorsFiller winSystem object creation. Less duplicate code.

Currently no use outside of tvos. Can be used for ios, so will put in ios-common

waitpid undef not required. Functions correctly with waitpid on both ios/tvos

…latformVersionDecoded Changes to a generic code path for GetBuildTargetPlatformVersionDecoded that utilises GetBuildTargetPlatformVersion to do the macro for the specific platform (ios and future tvos)

Initial commit for TVOS platform.

binary-addon building added to xcode project for tvOS. The default behaviour is to add all addons to the project, but not add as a dependency. This means the addons will NOT be built be default. Documentation updated and shows how to selectively build addons if required and how to add the auto building dependecy to the Xcode project.

Implement some todo's regarding sleep/wake workflow. Stop/start ActiveAE on sleep/wake Stop/start All network services on sleep/wake combine and streamline methods involved with sleep/wake

fuzzard · 2020-01-08T09:09:48Z

Jenkins build this please

chkpnt · 2020-01-08T13:16:05Z

docs/README.tvOS.md

-```
-make -C tools/depends/target/binary-addons ADDONS="audioencoder.flac pvr.vdr.vnsi audiodecoder.snesapu"
-```
+**TIP:** BUILD_DIR can be omitted, and project will be created in $HOME/kodi/build


I just tried it out: The project has been created in ./build.

Not sure I see the problem?

All conventions in the readme follow on from prior steps, so if you set it up as described, Kodi source gets cloned into $HOME/Kodi, which is where you execute the cmakebuildsys command. This is then going to be ./build, as you are in the directory, or long form $HOME/Kodi/build

You are right, I'm sorry. I've missunderstood the sentence, thought $HOME/kodi/build was hard coded somewhere.

fuzzard · 2020-01-09T20:28:40Z

Jenkins build this please

fuzzard · 2020-01-10T07:25:32Z

Jenkins build this please

fuzzard · 2020-01-10T07:26:47Z

Jenkins build this please

Memphiz · 2020-01-10T12:24:59Z

Yay - congrats - thx and well done to all involved!

pogarek · 2020-01-10T14:04:54Z

Indeed. Well done and congrats. Finally it happened !

fuzzard added CMake v19 Matrix Platform: tvOS Component: Build labels Nov 2, 2019

fuzzard added this to the Matrix 19.0-alpha 1 milestone Nov 2, 2019

fuzzard requested review from Memphiz, kambala-decapitator, Rechi and sy6sy2 November 2, 2019 20:39

Rechi requested changes Nov 2, 2019

View reviewed changes

fuzzard force-pushed the master-ATV branch 3 times, most recently from 592a903 to ea72f99 Compare November 3, 2019 09:16

Rechi reviewed Nov 4, 2019

View reviewed changes

fuzzard force-pushed the master-ATV branch from ea72f99 to 96965be Compare November 4, 2019 10:00

Rechi reviewed Nov 4, 2019

View reviewed changes

fuzzard force-pushed the master-ATV branch 2 times, most recently from 676cf58 to 1c9553b Compare November 4, 2019 21:43

fuzzard force-pushed the master-ATV branch from 1c9553b to 84120c4 Compare November 7, 2019 01:05

jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Nov 7, 2019

fuzzard force-pushed the master-ATV branch from 84120c4 to 54513ba Compare November 9, 2019 05:30

jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Nov 9, 2019

fuzzard force-pushed the master-ATV branch from 54513ba to ef785f3 Compare November 9, 2019 09:03

fuzzard force-pushed the master-ATV branch 3 times, most recently from 7645479 to 791398d Compare November 18, 2019 00:07

fuzzard force-pushed the master-ATV branch 2 times, most recently from 788bad9 to b5f3375 Compare January 5, 2020 20:36

fuzzard force-pushed the master-ATV branch from b5f3375 to 3209a8c Compare January 6, 2020 03:25

fuzzard force-pushed the master-ATV branch from 3209a8c to 10593e8 Compare January 6, 2020 08:20

fuzzard and others added 9 commits January 8, 2020 19:08

[settings] SettingOptionsMonitorsFiller refactor

19c43b3

implement WIN_SYSTEM_CLASS define to refactor SettingOptionsMonitorsFiller winSystem object creation. Less duplicate code.

[ios-common] relocate Darwinnsuserdefaults to ios-common

87d12d6

Currently no use outside of tvos. Can be used for ios, so will put in ios-common

[ios/tvos] Relocate CPUInfo for DarwinEmbed platforms

5b86738

[ios/tvos] Python3 patch update - remove waitpid define

5a5db21

waitpid undef not required. Functions correctly with waitpid on both ios/tvos

[DarwinEmbedded] Darwinembedded generic code path for GetBuildTargetP…

4258a6d

…latformVersionDecoded Changes to a generic code path for GetBuildTargetPlatformVersionDecoded that utilises GetBuildTargetPlatformVersion to do the macro for the specific platform (ios and future tvos)

[tvOS] Initial Platform Commit for Apple TVOS

5b152cd

Initial commit for TVOS platform.

[TVOS] sleep state management

77596ca

Implement some todo's regarding sleep/wake workflow. Stop/start ActiveAE on sleep/wake Stop/start All network services on sleep/wake combine and streamline methods involved with sleep/wake

[DarwinEmbedded] Support xcode 11 certificate naming scheme

9bfbe69

fuzzard force-pushed the master-ATV branch from 10593e8 to 9bfbe69 Compare January 8, 2020 09:08

chkpnt reviewed Jan 8, 2020

View reviewed changes

fuzzard merged commit fd07663 into xbmc:master Jan 10, 2020

sy6sy2 mentioned this pull request Jan 10, 2020

[Apple TV] tvOS support for Kodi (WIP) #15956

Closed

13 tasks

fuzzard deleted the master-ATV branch August 16, 2023 03:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Apple TV Platform #16860

Implement Apple TV Platform #16860

fuzzard commented Nov 2, 2019

Rechi left a comment

fuzzard commented Nov 3, 2019

Rechi left a comment

Rechi Nov 4, 2019

fuzzard Nov 4, 2019

Rechi Nov 5, 2019

fuzzard Nov 5, 2019

Rechi Nov 5, 2019

fuzzard Nov 5, 2019

fuzzard commented Nov 4, 2019

Rechi commented Nov 5, 2019

fuzzard commented Nov 5, 2019 •

edited

Loading

fuzzard commented Jan 5, 2020

fuzzard commented Jan 6, 2020

fuzzard commented Jan 6, 2020

fuzzard commented Jan 7, 2020

fuzzard commented Jan 7, 2020

fuzzard commented Jan 8, 2020

fuzzard commented Jan 8, 2020

chkpnt Jan 8, 2020

fuzzard Jan 8, 2020

chkpnt Jan 9, 2020 •

edited

Loading

fuzzard commented Jan 9, 2020

fuzzard commented Jan 10, 2020

fuzzard commented Jan 10, 2020

Memphiz commented Jan 10, 2020

pogarek commented Jan 10, 2020

Implement Apple TV Platform #16860

Implement Apple TV Platform #16860

Conversation

fuzzard commented Nov 2, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

Checklist:

Rechi left a comment

Choose a reason for hiding this comment

fuzzard commented Nov 3, 2019

Rechi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fuzzard commented Nov 4, 2019

Rechi commented Nov 5, 2019

fuzzard commented Nov 5, 2019 • edited Loading

fuzzard commented Jan 5, 2020

fuzzard commented Jan 6, 2020

fuzzard commented Jan 6, 2020

fuzzard commented Jan 7, 2020

fuzzard commented Jan 7, 2020

fuzzard commented Jan 8, 2020

fuzzard commented Jan 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chkpnt Jan 9, 2020 • edited Loading

Choose a reason for hiding this comment

fuzzard commented Jan 9, 2020

fuzzard commented Jan 10, 2020

fuzzard commented Jan 10, 2020

Memphiz commented Jan 10, 2020

pogarek commented Jan 10, 2020

fuzzard commented Nov 5, 2019 •

edited

Loading

chkpnt Jan 9, 2020 •

edited

Loading