fix clashing XBMCK_EJECT and XBMCK_FAVORITES

[bam80]

The clash:
XBMCK_FAVORITES = 0x14d,
XBMCK_EJECT = 333,
0x14d == 333

Description

Motivation and Context

XBMCK_EJECT wrongly maps to XBMCVK_FAVORITES

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[Rechi]

• Please follow the code guidelines.
• The PR title indicates that only the clashing XBMCK_EJECT and XBMCK_FAVORITES was fixed, but there is also a new key (XBMCK_SUBTITLE) added.
• The commit message of your second commit has to be adjusted, because Update XBMC_keysym.h doesn't describe what change was done.

[bam80]

• The PR title indicates that only the clashing XBMCK_EJECT and XBMCK_FAVORITES was fixed, but there is also a new key (XBMCK_SUBTITLE) added.

• The commit message of your second commit has to be adjusted, because Update XBMC_keysym.h doesn't describe what change was done.

Sorry, it occurred here accidentally. Fixed

[Rechi]

code style is now correct

[bam80]

@Rechi anything left?

[Rechi]

All my objections are fixed.

[bam80]

Can we merge it then?

[bam80]

@Rechi sorry I didn't understand why the patch was not merged? Please explain what else needed.

[bam80]

@ronie @lrusak Could you guys help me to merge this?
I'm waiting for a week and still no go, I think it's too much for such a simple patch.
Please tell me if there is a reason.
@garbear @ksooo

[yol]

lgtm, verified that XBMCK_EJECT is not a original SDL scancode (important for OS X which still uses SDL and 1:1 keycode mapping)

[yol]

I'm waiting for a week and still no go, I think it's too much for such a simple patch. Please tell me if there is a reason.

The reason is that we are all volunteers hacking on Kodi in their spare time. Please understand that such comments only serve to decrease the motivation for any developer to look at it. Besides, nothing in Kodi is simple ;-) I'm actually not 100% sure this will not break something, but I checked the cases I could think of.

[yol]

UWP build failure unrelated

[bam80]

@yol I was just asking for any reply that devs are aware of the patch and it's not forgotten.
We are all the volunteers and it has nothing to do with it.
I'm new to making PR to this project so maybe I just don't have a notion yet how things are doing.

Thanks for merging.