Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Priorize timer instead HDMI_AUDIOPLUG on refreshrate switch #16978

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Nov 29, 2019

Description

In the current implementation a display mode change is finished, if the android device implements HDMI_AUDIO_PLUG event and if this intent arrives with state "connected", regardless what "delay after refreshrate" is set in kodi system settings.

This PR changes the behaviour in a way that timer has higher priority and the end of the mode switch is when the timer expires.

Motivation and Context

Users need the timer because of:

  • HDCP issues on NVIDIA Shield TV (OS 8.0.1+)
  • Multi - HDMI connections (Box -> AVR -> TV)
  • ...

How Has This Been Tested?

Tested on "broken" NVIDIA Shield TV 8.0.1 playing DRM secure, which requires HDCP.

  • Without this PR Vide starts, after about 2 seconds HDCP screen pops up and playback refuses
  • With this PR and set delay to 5 seconds, stream starts later, but HDCP errors disappear.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@ksooo
Copy link
Member

ksooo commented Nov 29, 2019

Runtime tested on 8.0.1 - works as described/expected.

@peak3d peak3d merged commit 4383a79 into xbmc:master Nov 29, 2019
@peak3d peak3d deleted the refreshrate branch November 29, 2019 20:53
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
[Android] Priorize timer instead HDMI_AUDIOPLUG on refreshrate switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants