Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProfileManager: Fall back to master profile if profile.xml not loadable / parseable #16987

Merged
merged 2 commits into from
Dec 9, 2019
Merged

ProfileManager: Fall back to master profile if profile.xml not loadable / parseable #16987

merged 2 commits into from
Dec 9, 2019

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Dec 2, 2019 •
edited
Loading

Fixes: #16617

Though I cannot test :-)

@fritsch fritsch added this to the Matrix 19.0-alpha 1 milestone Dec 2, 2019
@fritsch fritsch added v19 Matrix Backport: Needed Type: Fix non-breaking change which fixes an issue labels Dec 2, 2019
@fritsch
Copy link
Member Author

fritsch commented Dec 2, 2019

I need someone with profiles, that could test this above version and see if it recovers.

@fritsch
Copy link
Member Author

fritsch commented Dec 2, 2019 •
edited
Loading

I reproduced it:

Old:

2019-12-02 11:04:04.736 T:18266   ERROR: CProfileManager: error loading special://masterprofile/profiles.xml, Line 8
                                            Error reading end tag.
2019-12-02 11:04:04.736 T:18266  NOTICE: special://profile/ is mapped to: special://masterprofile/
2019-12-02 11:04:04.736 T:18266   FATAL: unable to load profile

New:

2019-12-02 11:26:12.319 T:3168  NOTICE: -----------------------------------------------------------------------
2019-12-02 11:26:12.319 T:3168    INFO: loading settings
2019-12-02 11:26:12.319 T:3168   ERROR: CProfileManager: error loading special://masterprofile/profiles.xml, Line 8
                                            Error reading end tag.
2019-12-02 11:26:12.319 T:3168   ERROR: Failed to load profile - might be corrupted - falling back to master profile

@fritsch fritsch mentioned this pull request Dec 2, 2019
Closed
7 tasks
@fritsch
Copy link
Member Author

fritsch commented Dec 2, 2019

jenkins build this please

@fritsch fritsch mentioned this pull request Dec 2, 2019
Merged
@fritsch
Copy link
Member Author

fritsch commented Dec 9, 2019

I will push this, as it's a last resort fix. If we get users to test the outtage (which did not happen the last 48 hours) - I will fix those separately.

@fritsch fritsch merged commit 5ff84c0 into xbmc:master Dec 9, 2019
@fritsch fritsch mentioned this pull request Dec 12, 2019
Closed
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
@fritsch @Maven85
Merge pull request xbmc#16987 from fritsch/profile
9a572c2 
ProfileManager: Fall back to master profile if profile.xml not loadable / parseable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

Kodi failing to open - recurring black screen (issue with profiles.xml and guisettings.xml)
2 participants
@fritsch @DaveTBlake