-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] fix build against python 3.8 #17021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a really bad idea. I remember reviewing the code in PythonInvoker and thinking we need to move away from accessing the internal thread state structures internal to python and I think there were even warnings in the documentation that this could be changed without notice. You can take this for now to get 3.8 working but I'm going to see if there's a compliant way to do the same thing (get access to the chain of thread states).
thanx for the feedback. |
# define Py_BUILD_CORE | ||
# undef HAVE_STD_ATOMIC | ||
/* for access to the fields of PyInterpreterState */ | ||
# include "internal/pycore_pystate.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include style is wrong, this in not a Kodi header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanx for the hint, updated.
[Python] fix build against python 3.8
Today my Manjaro linux installation updated to python 3.8.0 and i was unable to compile Kodi.
As mentioned in #16560 we are not compatible with the current python version.
This PR implements the workaround as suggested in that issue report.
fixes #16560