Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vfs][addons] fix media view from addon given content #17066

Merged
merged 1 commit into from Jan 6, 2020

Conversation

AlwinEsch
Copy link
Member

Description

Before was by opening of e.g. RAR file(s) the view on Videos, Music...
not shown.

Change only related to VFS addons in CFileDirectoryFactory, all
other formats not affected.

Inside compressed files seems a m_bIsFolder of CFile as true not to
handle the source from addon correct.

Motivation and Context

How Has This Been Tested?

This change is tested with old and reworked vfs.rar addon, vfs.sftp
and vfs.libarchive. There it has worked correct, further (as note)
becomes in reworked vfs.rar the directory support of rar files brought
back.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch AlwinEsch added Type: Fix non-breaking change which fixes an issue Component: Binary add-ons v19 Matrix labels Dec 21, 2019
@AlwinEsch AlwinEsch added this to the Matrix 19.0-alpha 1 milestone Dec 21, 2019
@AlwinEsch AlwinEsch force-pushed the fix-vfs-addon-view branch 2 times, most recently from c14d5ae to 968879f Compare January 4, 2020 07:17
Before was by opening of e.g. RAR file(s) the view on Videos, Music...
not shown.

Change only related to VFS addons in CFileDirectoryFactory, all
other formats not affected.

Inside compressed files seems a m_bIsFolder of CFile as true not to
handle the source from addon correct.
@AlwinEsch AlwinEsch merged commit 6a07bea into xbmc:master Jan 6, 2020
@AlwinEsch AlwinEsch deleted the fix-vfs-addon-view branch January 6, 2020 00:03
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
[vfs][addons] fix media view from addon given content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Binary add-ons Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant