Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matrix] update unrar to newest version #50

Merged
merged 13 commits into from
Jan 6, 2020
Merged

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Dec 30, 2019

Pervers unrar update 😁 (the other request is closed)

It is now on latest unrar version 5.8.5 and updated from 2005 to 2019 😰 😥 😎 😄

Still not completed and some parts need to improve and cleanup, but the tests do work now 😅. Also need the commit flow a bit of changes.

It supports now also RAR5 files, only does it currently not use Kodi's hackway to read and seek inside RAR5. Hope to become this also working for them (if not "Solid" RAR package)

EDIT:

  • Hackway on RAR5 with direct read works also. Only requirement, the RAR must not compressed.
  • p8-platform usage complete removed
  • This need [vfs][addons] fix media view from addon given content xbmc#17066 to work correct!
  • If RAR separated to more as one file and one is missing, is it no more shown in list (to prevent use and possible crashes)
  • Show password dialog if required

New addon views:
Screenshot_20200105_192742

Screenshot_20200105_193949

The progress if takes longer:
Screenshot_20200105_194234

@AlwinEsch
Copy link
Member Author

The work is mostly done and if OK it can be in.

@AlwinEsch
Copy link
Member Author

Tested on Mac, Linux, Android and Windows, it works 😄

@AlwinEsch AlwinEsch merged commit 394c96e into xbmc:Matrix Jan 6, 2020
@AlwinEsch AlwinEsch deleted the rar-rework branch January 6, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant