Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGUIDialogSelect: fix focusing list / buttons after 6d34db9900 #17115

Merged

Conversation

Montellese
Copy link
Member

Description

In #16802 the possibility to pre-select the OK button in the select dialog (CGUIDialogSelect) has been introduced. Unfortunately this broke the possibility to change the focus to the list of dependencies and select one of them to view its details.

Motivation and Context

Fix the possibility to change the focus to the list of dependencies and select one of them to view its details.

How Has This Been Tested?

Manually.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Montellese Montellese added Type: Fix non-breaking change which fixes an issue Component: Add-ons v19 Matrix labels Jan 1, 2020
@Montellese Montellese added this to the Matrix 19.0-alpha 1 milestone Jan 1, 2020
@Montellese Montellese added this to In progress in General (roadmap) via automation Jan 1, 2020
General (roadmap) automation moved this from In progress to Reviewer approved Jan 2, 2020
Copy link
Contributor

@gusandrianos gusandrianos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Montellese
Copy link
Member Author

@ronie could you give it a try as well and verify that it works?

Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can confirm it fixes the issue

@Montellese
Copy link
Member Author

@ronie Thanks for the fast feedback.

@Montellese Montellese merged commit 8c0dc7b into xbmc:master Jan 2, 2020
General (roadmap) automation moved this from Reviewer approved to Done Jan 2, 2020
@Montellese Montellese deleted the bugfix/select_addon_dependencies branch January 2, 2020 13:04
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
…endencies

CGUIDialogSelect: fix focusing list / buttons after 6d34db9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Add-ons Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants