-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pvr] always add new members to group at end in group manager #17348
Conversation
@ksooo are you ok with the logic being in this class or would you prefer the max channel number is returned from the groups class? |
yes. :-) |
Add a new method? => |
Looking at the documentation of https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/channels/PVRChannelGroup.h#L153 => |
be54e63
to
00a8496
Compare
00a8496
to
5b5d5f1
Compare
5b5d5f1
to
bc66779
Compare
Thanks guys. Can we just merge it if it works for you, and I'll check when it builds itself tomorrow? Will it work? |
Still can't check it, the latest nightly is git20200117 |
Those nightlies are not created by team Just wait I guess. |
Still see it's headed '“Kodi” team' on the Launchpad:
|
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
[pvr] always add new members to group at end in group manager
Description
Always add new channels to groups at the end in group manager.
Motivation and Context
Then adding support for group specific channel numbering and numbering from 1 (#16593) logic was missed in the group manager GUI.
Fixes: #17324
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: