[pvr] always add new members to group at end in group manager

[phunkyfish]

Description

Always add new channels to groups at the end in group manager.

Motivation and Context

Then adding support for group specific channel numbering and numbering from 1 (#16593) logic was missed in the group manager GUI.

Fixes: #17324

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[phunkyfish]

@ksooo are you ok with the logic being in this class or would you prefer the max channel number is returned from the groups class?

[ksooo]

would you prefer the max channel number is returned from the groups class?

yes. :-)

[ksooo]

Add a new method? => CPVRChannelGroup::AppendToGroup(…)

[ksooo]

Looking at the documentation of CPVRChannelGroup::AddToGroup it seems, that this method's implementation needs to be fixed.

https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/channels/PVRChannelGroup.h#L153

=> @param channelNumber The channel number of the channel to add. Use empty channel number to add it at the end.

[bam80]

Thanks guys. Can we just merge it if it works for you, and I'll check when it builds itself tomorrow? Will it work?

[bam80]

Still can't check it, the latest nightly is git20200117

[phunkyfish]

Those nightlies are not created by team
Kodi so afraid I don’t know when the next one gets released.

Just wait I guess.

[bam80]

Those nightlies are not created by team

Still see it's headed '“Kodi” team' on the Launchpad:
https://launchpad.net/~team-xbmc/+archive/ubuntu/xbmc-nightly?field.series_filter=eoan

Kodi Nightly Builds
PPA description
Official Team Kodi nightly builds.