Don't try to generate a thumb for unresolved plugin path #17352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmrector
added
Type: Fix
|
LGTM |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Feb 17, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Feb 19, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Feb 26, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
Don't try to generate a thumb for unresolved plugin path
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
Don't try to generate a thumb for unresolved plugin path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #17202, giving plugins a loader in
CFileFactorymeans they make it to the thumbloader now, but it still can't process them.Motivation and Context
Fixes a Kodi crash when a generated thumbnail is requested for a plugin path.
How Has This Been Tested?
Quick runtime testing.