[addons] fix stupid circumstance with addon settings on folder with file extension #17449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile extension Found this when adding settings to vfs.rar. There called this place with "special: //profile/addon_data/vfs.rar", this was seen by "CFileDirectoryFactory::Create" as a file and tried to open with vfs.rar addon. This logically leads to an error because it is only a folder. The slash is left now on the folder so that it is recognized as a folder.
AlwinEsch
added
Type: Fix
phunkyfish
added
the
PR Cleanup: Needs Review
|
Is this OK? |
|
Would this also impact python addons? |
|
Actually not directly, since it only refers to the storage of the data at Use in this line only https://github.com/xbmc/xbmc/blob/5c96aaa455782c2842c123c7e40c665c8aa736c5/xbmc/addons/Addon.cpp#LL164-L171. But it would also be good if a second could test it, so that there is not something hidden in it. |
phunkyfish
approved these changes
Mar 14, 2020
|
Thanks a lot! |
AlwinEsch
removed
the
PR Cleanup: Needs Review
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Mar 16, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
[addons] fix stupid circumstance with addon settings on folder with file extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found this when adding settings to vfs.rar.
There called this place with "special://profile/addon_data/vfs.rar", this was seen
by "CFileDirectoryFactory::Create" as a file and tried to open with vfs.rar addon.
This logically leads to an error because it is only a folder.
The slash is left now on the folder so that it is recognized as a folder.
Motivation and Context
Got a big question mark when I added the settings and they weren't saved but worked when addon was disabled.
That these slashes have been omitted has been in history since Kodi's "github". Do not see the need to leave them out and the test went well.
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: