add VideoPlayer.offset() infolabels #17576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronie
added
Type: Feature
|
Looks to be working as expected
Thanks ronie |
ksooo
reviewed
Mar 29, 2020
|
Tested all kinds of scenarios. And everything worked as expected. |
ronie
force-pushed
the
videoplayer-offset
branch
from
67b7f6c
to
7f9e452
Compare
|
thanx @ksooo, updated as suggested. |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 6, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
add VideoPlayer.offset() infolabels
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
add VideoPlayer.offset() infolabels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds VideoPlayer.offset() and VideoPlayer.position() support for VideoPlayer infolabels.
it allows skins to display info for (amongst others) the next item during playback.
offset() is relative to the currently playing video in a playlist
position() is the absolute position in a playlist
@sualfred @gade01 @jjd-uk