-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport][LanguageCodes] Add "Swiss german" and "Portuguese (Brazil)" #17662
Conversation
hm, getting in trouble due to |
Yes there was a update related to this on Matrix. @Rechi how we handle the differences about both, take the currently used clang code on master to make easier for backports or change then to Leia's style, where then can be a bit heavy? I prever to use the one from master also on Leia. |
Can you remove the style cleanups, has not thought so far, sorry. There on Leia are only fixes added. I'm see your last commit as a half fix, as that the "Swiss german" then wrongly not is used and OK to bring. If you see them as fix too, it can be in, only then the label must be changed to fix. |
@AlwinEsch ok, now applied only the fix itself which is apparently a 1-liner. it would now result in jenkins-clang-complains about the array-format, but i'm fine if it stays this way |
...as you can see the huge diff 😀 both versions do technically the same (language addition) |
For me OK, as the selection is fixed and can say now "ei Grüezi mitenand" 😀 |
we should keep the cosmetic changes especially for the arrays, because future contributors would run into oddities when they're touched later (like already happened on master). agree somehow hard to review, but therefore the split by commit. |
@howie-f lets only include the single commit which is the fix. Any refactoring needs to be omitted as the Leia branch is fixes only. |
@phunkyfish oh, ok, read your comment too late, will remove the cosmetics then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
jenkins build this please |
Thanks @howie-f ! |
Backport of #17626 and #17689 to Leia
adds the "swiss german" and also "portuguese (brazil)" language code
to the language code expander
Checklist: