Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][Android] Use releaseOutputBufferAtTime for valid frames #17945

Merged
merged 1 commit into from
May 25, 2020

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented May 24, 2020

Description

Backport of #17943:

In our JNI implementation releaseOutputBuffer(int index, long renderTimeStampNs) was missing and compiler has cast our renderTimestamp to the bool render value of releaseOutputBuffer(int index, bool render) which causes an immediate render. This PR updates to the extended libandroidJNI library and calls the correct implementation.
The issue was introduced for master in #17611 and fror Leia backported in #17613

Motivation and Context

Micro stutters were reported e.g. here: https://forum.kodi.tv/showthread.php?tid=354295

How Has This Been Tested?

Playback of 25fps videos on 50Hz display / NVIDIA Shield 2017, Micro stutters are sometimes visible.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants