[Android] MediaCodec: reimplement JNI (instead NDK) #17611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peak3d
added
Type: Fix
fritsch
reviewed
Apr 5, 2020
xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAndroidMediaCodec.cpp
Show resolved
Hide resolved
7 tasks
|
Test reports are fine as well: https://forum.kodi.tv/showthread.php?tid=336151&pid=2937842#pid2937842 |
fritsch
approved these changes
Apr 5, 2020
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 6, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
This was referenced May 24, 2020
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
[Android] MediaCodec: reimplement JNI (instead NDK)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch back from NDK to JNI in MediaCodec video decoder (android)
Motivation and Context
~2years ago we switched from JNI to NDK in MediaCodec video decoder.
Because some things are missing / not working in NDK, we still use partitialy JNI.
Latest example is MediaCodec::setVideoScalingMode. It is not implemented in NDK but we use it for e.g. AFTV devices which have videos stretched (https://forum.kodi.tv/showthread.php?tid=336151&pid=2936959#pid2936959)
The discussion with the NDK devs (github issue: android/ndk#1224 (comment)) was not very fruitful, so I decided to go back to JNI and have everything available.
How Has This Been Tested?
Play h.264 video with 1920x882px on AFTV. Without this JNI / setVideoScalingMode implementation the video was stretched in height, the PR fixes the issue.
Beside this I crosschecked on NVIDIA shield, video AR is still fine.
Types of change