[json] - move the initialisation of json-rpc from loadprofile into netwo... #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twork.startservices. This fixes the problem that json-rpc is not available during the login dialog in multi user environments
|
The problem with making JSON-RPC available this early is that the behaviour on calls like VideoLibrary and AudioLibrary methods might be undefined because some profile might not have access to the video and/or audio library. Same problem with accessing sources through Files.GetDirectory and Files.GetFileDetails as some sources might be locked in one profile but not in another. I don't really know much about all this profile stuff as I've never ever used it so I don't know what exactly will happen. |
|
Ok we consider this a known design problem for frodo imo (fixing it the way i proposed would introduce a lot of problems and support hassle). closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rk.startservices. This fixes the problem that json-rpc is not available during the login dialog in multi user environments.
@Montellese ftw :)