Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI][ControlGroupList] Update scroller sizes when list size changes #18907

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Dec 6, 2020

Description

This fixes the scroller size and position for cases in which the respective container is updated to contain additional items. This is visible for example in the addon settings dialog when you enable a setting that changes the visibility status of other items in the same list.

@CastagnaIT I think you'll have to be the testing monkey here :)

Motivation and Context

Fixes #18637

How Has This Been Tested?

With netflix settings dialog as shown in the issue report. Tested a bunch of other windows with no regressions observed.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality Component: GUI engine v19 Matrix labels Dec 6, 2020
@enen92 enen92 added this to the Matrix 19.0-RC1 milestone Dec 6, 2020
@enen92 enen92 requested a review from ronie December 6, 2020 16:36
@ronie
Copy link
Member

ronie commented Dec 8, 2020

@enen92 it's not working as expected for me...
in my test i used these addon settings: https://paste.kodi.tv/raxawidogi

addon settings dialog:
s1

expected result after enabling the first setting:
s2

actual result after enabling the first setting: the list scrolls to the end
s3

@enen92
Copy link
Member Author

enen92 commented Dec 8, 2020

Good catch @ronie, thanks

@enen92 enen92 added the WIP PR that is still being worked on label Dec 8, 2020
@CastagnaIT
Copy link
Collaborator

@enen92 I can confirm the same behavior with the old setting version

@enen92 enen92 removed the WIP PR that is still being worked on label Dec 8, 2020
@enen92
Copy link
Member Author

enen92 commented Dec 8, 2020

@ronie @CastagnaIT please retest

@enen92 enen92 changed the title [gui][grouplistcontrol] Fix scrollbar size when new items are added t… [GUI][ControlGroupList] Update scroller sizes when list size changes Dec 8, 2020
Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! :-)

@enen92 enen92 merged commit 1ee72b0 into xbmc:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar height not updated in settings window
3 participants