-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windowing/gbm: hide and disable setting Use Display As Clock #18950
Conversation
Signed-off-by: Matthias Reichl <hias@horus.com>
Use display as clock is not supported on GBM and before the multi-windowing change it has been hidden in settings via gbm.xml. Hide it so it can't be enabled in videoplayer settings and also disable it - otherwise users who previously enabled it would be left without audio passthrough and no option to fix this via the GUI. Signed-off-by: Matthias Reichl <hias@horus.com>
e160f19
to
cacf601
Compare
updated with suggested changes |
@DaveTBlake it's your button 😄 |
AFAIK, the speedup functionality https://forum.kodi.tv/showthread.php?tid=10023&pid=2379972#pid2379972 depends on "Sync playback to display". This is one of THE killer functions within Kodi for me to watch movies and TV episodes faster. Please be sure to provide an alternative to keep it working. |
Please don't spam old PR's. If you have a concern please bring it up in the forum thanks. |
Well, 2 days is certainly far from old, and you have taken note of it so my work is done. I don't want to waste your time by having you read this twice. |
Description
Use display as clock is not supported on GBM and before the
multi-windowing change it has been hidden in settings via gbm.xml.
Hide it in settings so it can't be enabled in player settings and
also make sure it's disabled in case it had been enabled before,
otherwise users would be left without audio passthrough and no
option to fix this via the GUI.
Motivation and Context
Restore behaviour prior to the multi-windowing change and make sure
users aren't able to select a known non-working option
How Has This Been Tested?
Runtime tested on LibreELEC RPi4, checked that previously enabled setting
is getting disabled (with a WARN in log) and that option is not shown in video
player settings.
Types of change
Checklist: