Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][Depends] New python build that fixes socket.ioctl #19215

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

Paxxi
Copy link
Member

@Paxxi Paxxi commented Feb 12, 2021

Description

Python build used for Windows incorrectly removed SIO_RCVALL causing socket.ioctl to not be available

Motivation and Context

#19204

How Has This Been Tested?

Tested with the addon provided in ##19204

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@DaveTBlake
Copy link
Member

Thanks @Paxxi, since Python related and v19 is all about Python I would have this in v19.0 despite being so near the planned date (and build changes making me nervous).

@DaveTBlake DaveTBlake added Type: Fix non-breaking change which fixes an issue v19 Matrix and removed v20 Nexus labels Feb 13, 2021
@DaveTBlake
Copy link
Member

DaveTBlake commented Feb 13, 2021

jenkins build this please
Or do the new package versions still need to pe uploaded?

@wsnipex
Copy link
Member

wsnipex commented Feb 13, 2021

jenkins build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants