-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSON]Add sort video items by original title - SortByOriginalTitle #19435
Conversation
Edit: forget the above, this is against master. Our process is anything new must be merged into master, and then a backport may be considered for the previous version after this (ie Matrix currently). |
jenkins build this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good apart from the missing JSON-RPC API version bump.
And please fix your commit messages to use at least a sentence like add support to sort items by original title
or something similar.
e507cde
to
40ea95d
Compare
I think that the first commit could also do with a better description too. For example: |
40ea95d
to
ef32d2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
@DaveTBlake do you want to hold this back as it poses the same issue as #19372 concerning JSON-RPC version bumps?
Yes, would be useful to hold merging this until after 19.2 point release it out. |
@DaveTBlake: I dont know, why build failed, when I set actual JSON version,
but, 19.2 is out already with 19.3 even? |
We don't allow merge commits in pull request. You need to |
7cd3c69
to
bcdf485
Compare
Thank you for the hint. I did it just now, lets see what Jenkins and you think about that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general but I found a few things that need to be addressed. It also looks like you lost the JSON-RPC version bump in your rebase.
I tried to adress your mentions, let me know how you see it, eventually I will rebase it again, when you will be happy. |
ba2e150
to
f209ee3
Compare
I did rebase, because I am leaving to week long holiday, just in case.. |
Fair point. I’ve get that pain. Let’s see can we get this merged. @DaveTBlake you ok with this being merged once the version is added? |
I am fine with bump number of JSON. Current is I believe 12.7.0. If somebody really merge this after resolving all other possible things, just tell me wanted version number, I will add it before squash/rebase at the end. |
Very usefull switch, when you use parser able to parse both Original and Localised titles. When xbmc/xbmc#19435 will be merged (Nexus hopefully), sort method will be also available for OriginalTitle. POC video in PR above.
f34ea2f
to
c182709
Compare
I added requested comment for translators, I added again JSON version (which was changed again 2 days ago), but I dont know if anyone merge this before another JSON version bump... |
@JimmyS83 please fix the clang-format issues, otherwise the PR wont get merged. |
c182709
to
50cc83b
Compare
I added formatting changes proposed by jenkins. |
50cc83b
to
5bdf41a
Compare
I think that one machine has problems with disc space or smth, otherwise everything should be OK. |
Jenkins build this please |
Merge me please :-) |
Thanks for sticking with it @JimmyS83! |
This is Matrix version of a (now closed) PR originally submitted for Leia - #19434
Description
Adds sort method, according
originaltitle
variable/infolabel, with fallback to standardsorttitle
,title
.Motivation and Context
Most of (newer) scrapers (such as default tmdb) supports scraping item
Title
in user’s choice language. They are able to store also original title intooriginaltitle
variable (infolabel).It could be displayed by skin in lists, etc. User can choose, which title he wants in lists, dynamically, even both of them for example.
The problem is, that Kodi lacks function to sort list according originaltitle. It supports only
Title
, andSorttitle
parameters.Sorttitle
is written to DB during scraping, so its not dynamic parameter at all.How Has This Been Tested?
Screenshots (if appropriate):
Example on dummy data, where both titles are visible to make a point more easilly: https://streamable.com/kgvjj9
Types of change
Checklist: