use CFileItem::IsSamePath() to match the item in OnPlayAndQueueMedia #1952

Merged
merged 1 commit into from Dec 18, 2012

Projects

None yet

3 participants

Member

Fixes the problem introduced by 682f121

fixes #13762

Jonathan Marshall use CFileItem::IsSamePath() to match the item in OnPlayAndQueueMedia,…
… and set the original_listitem_url for bluray selection. fixes #13762
57f6432
Member
elupus commented Dec 18, 2012

Looks alright to me. But the media window is getting rather messy :/. I wonder if we couldn't do away with direct playback and always make use of a playlist. Feels it would simplify things.

@jmarshallnz jmarshallnz merged commit 2f1fd18 into xbmc:master Dec 18, 2012

This still happens on the http://mirrors.xbmc.org/nightlies/win32/XBMCSetup-20121219-46e045e-master.exe nightly which includes this commit.

I confirmed that the last nightly this does not happen with is http://mirrors.xbmc.org/nightlies/win32/XBMCSetup-20121214-a5f1630-master.exe.

Member

IsFilePath fails for videodb items, as an item_start property is created while one shouldn't exist - simple fix.

It works fine for items not in the video db.

Member

See b686293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment