use CFileItem::IsSamePath() to match the item in OnPlayAndQueueMedia #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and set the original_listitem_url for bluray selection. fixes xbmc#13762
|
Looks alright to me. But the media window is getting rather messy :/. I wonder if we couldn't do away with direct playback and always make use of a playlist. Feels it would simplify things. |
jmarshallnz
added a commit
that referenced
this pull request
Dec 18, 2012
use CFileItem::IsSamePath() to match the item in OnPlayAndQueueMedia
|
This still happens on the http://mirrors.xbmc.org/nightlies/win32/XBMCSetup-20121219-46e045e-master.exe nightly which includes this commit. |
|
I confirmed that the last nightly this does not happen with is http://mirrors.xbmc.org/nightlies/win32/XBMCSetup-20121214-a5f1630-master.exe. |
|
IsFilePath fails for videodb items, as an item_start property is created while one shouldn't exist - simple fix. It works fine for items not in the video db. |
|
See b686293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem introduced by 682f121
fixes #13762