[Fix] Videoscanner should not skip sftp/ssh sources #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. You also added win32 defines there - did you test compile it on windows or any other platforms beside linux? |
|
I've compiled this on Windows Vista (32-bit) and Linux. I've updated the original comment to reflect this. |
|
signed-off for osx and ios (buildtested + runtimetest on osx at least didn't break sshfs access ;) ). |
ghost
assigned 
|
works for me on ubuntu |
|
Squash it down to a single commit (git rebase -i HEAD~3) and I'll pull it. Let me know via commenting when done (else I won't get notified) |
…an SFTP url represents a directory or not. Fixes ticket xbmc#13784. Refactored CSFTPSession::Exists() into FileExists() and DirectoryExists() methods, and have CSFTPFile and CSFTPDirectory classes use them. This means that Exists() calls on these classes correctly only return true if the url refers to an item of the appropriate type (e.g. a file or a directory).
|
Hopefully that's done the trick. I'm afraid this is my first serious outing with git, so this is a bit of a trial-by-fire! :-) Many thanks, |
|
Looks good - thanks! |
jmarshallnz
added a commit
that referenced
this pull request
Jan 25, 2013
…_sftp [Fix] Videoscanner should not skip sftp/ssh sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override CSFTPDirectory::Exists() method to correctly report whether an SFTP url represents a directory or not.
Fixes ticket #13784.
Refactored CSFTPSession::Exists() into FileExists() and DirectoryExists() methods, and have CSFTPFile and CSFTPDirectory classes use them.
This means that Exists() calls on these classes correctly only return true if the url refers to an item of the appropriate type (e.g. a file or a directory).
This has been tested under Linux (Ubuntu 12.04) and Windows Vista (32-bit).