[skins] Remove player.displayafterseek in skins in favor of Player.Ha… #21380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sPerformedSeek(3)
enen92
added
Type: Improvement
This was referenced May 20, 2022
jojobrogess
added a commit
to jojobrogess/skin.auramod
that referenced
this pull request
Feb 14, 2023
https://forum.kodi.tv/showthread.php?tid=363553&pid=3098753#pid3098753 2022-05-22 - Removed Player.DisplayAfterSeek boolean condition The old Player.DisplayAfterSeek boolean condition was a design flaw of Kodi since it was coupling the videoplayer with GUI components. It was removed and replaced by the previously added Player.HasPerformedSeek(interval) boolean condition. By default Player.DisplayAfterSeek was valid for 2.5 seconds after a seek. To retain similar behaviour please use Player.HasPerformedSeek(3). Estuary and estouchy were adapted in xbmc/xbmc#21380 PR: xbmc/xbmc#21425
detobel36
pushed a commit
to detobel36/skin.auramod
that referenced
this pull request
Aug 8, 2024
https://forum.kodi.tv/showthread.php?tid=363553&pid=3098753#pid3098753 2022-05-22 - Removed Player.DisplayAfterSeek boolean condition The old Player.DisplayAfterSeek boolean condition was a design flaw of Kodi since it was coupling the videoplayer with GUI components. It was removed and replaced by the previously added Player.HasPerformedSeek(interval) boolean condition. By default Player.DisplayAfterSeek was valid for 2.5 seconds after a seek. To retain similar behaviour please use Player.HasPerformedSeek(3). Estuary and estouchy were adapted in xbmc/xbmc#21380 PR: xbmc/xbmc#21425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sPerformedSeek(3)
Description
Follow up after #21366 has been merged. This removes all references to
Player.DisplayAfterSeekfrom estuary and estouchy in favor ofPlayer.HasPerformedSeek(3). Display after seek by default is valid for 2.5 seconds which is pretty much the same as a seek event in the last 3 seconds.Runtime tested to confirm the offsets are correctly shown in the interface. E.g. after seeking a chapter:
Luckily this didn't even needed skin timers :)
Next step is the removal of
player.displayafterseekfrom the core, but only for Alpha 2.