Fix sometimes select plugin setting from context menu not works problem. #2255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, when we are in a plugin source dir, if selected item's path is not a plugin/script path, e.g. raw final http url, select 'Plugin Settings' from the item's context menu items will now show the plugin's setting dialog.
that's because the current code only use the selected item's path's hostname to get plugin/addon, it will fail in condition I mentioned.
I checked codes to show the context menu, there's condition like this:
obviously we will lost if the item is an http url item in a plugin dir in current code, so here's the fix PR.