Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport][Subtitles][WebVTT] Fix reversed pts offset correction #23128

Merged
merged 1 commit into from Apr 14, 2023
Merged

[backport][Subtitles][WebVTT] Fix reversed pts offset correction #23128

merged 1 commit into from Apr 14, 2023

Conversation

CastagnaIT
Copy link
Collaborator

Description

backport of #23124

Motivation and context

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CastagnaIT CastagnaIT requested a review from enen92 April 10, 2023 07:46
@CastagnaIT CastagnaIT added this to the Nexus 20.2 milestone Apr 10, 2023
enen92
enen92 reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible cherry-pick the comment from the other PR too

@enen92 enen92 merged commit 16c0b49 into xbmc:Nexus Apr 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enen92 enen92 enen92 approved these changes

Assignees
No one assigned
Labels
Component: Subtitles Type: Backport Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Milestone
Nexus 20.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CastagnaIT @enen92