Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][Subtitles][WebVTT] Fix reversed pts offset correction #23128

Merged
merged 1 commit into from
Apr 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ OverlayMessage COverlayCodecWebVTT::Decode(DemuxPacket* pPacket)

m_webvttHandler.Reset();

m_webvttHandler.SetPeriodStart(pPacket->m_ptsOffsetCorrection);
// WebVTT subtitles has no relation with packet PTS then if
// a period/chapter change happens (e.g. HLS streaming) VP can detect a discontinuity
// and adjust the packet PTS by substracting the pts offset correction value,
// so here we have to adjust WebVTT subtitles PTS by substracting it at same way
m_webvttHandler.SetPeriodStart(pPacket->m_ptsOffsetCorrection * -1);

if (m_isISOFormat)
{
Expand Down