Dllloader cleanup #23220
Merged
Dllloader cleanup #23220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Cleanup
thexai
reviewed
Apr 30, 2023
| { "ungetc", -1, (void*)dll_ungetc, NULL }, | ||
| { "_fdopen", -1, (void*)dll_fdopen, NULL }, | ||
| { "clearerr", -1, (void*)dll_clearerr, NULL }, | ||
| { "_close", -1, (void*)dll_close }, |
There was a problem hiding this comment.
Suggested change
| { "_close", -1, (void*)dll_close }, | |
| { "_close", -1UL, (void*)dll_close }, |
Not directly related with this PR but changing -1 to -1UL fixes a lot of warnings:
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(39,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(40,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(42,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(43,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(44,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(45,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(46,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
04:56:31 C:\jenkins-workspace\workspace\WIN-64\xbmc\cores\DllLoader\Win32DllLoader.cpp(47,36): warning C4838: conversion from 'int' to 'unsigned long' requires a narrowing conversion [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
There was a problem hiding this comment.
Yea thanks. I can do some extra adjustments in a follow up PR.
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
thexai
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a ton of unused (possibly non working) code. This code has been around for a long time with little amount of change. I was finally able to untangle it which allows removing a few thousand lines.
The code has been generating a lot of warnings and instead of fixing the unused code we can just remove it. This allows us to focus on the code that is actually used.
The only real change is in
Win32DllLoaderbut there should be no functional change.This also drops support for the
Dllloaderclass which isn't actually used on any currently supported platform.There is more unused methods and members in some classes in
cores/DllLoaderbut I wanted to do the minimal changes required to actually remove the bulk of the unused code.What is the effect on users?
None