Dllloader cleanup round 2 #23276
Merged
Dllloader cleanup round 2 #23276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
lrusak
added
Type: Fix
thexai
reviewed
May 14, 2023
thexai
approved these changes
May 17, 2023
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
lrusak
force-pushed
the
dllloader-cleanup-next
branch
from
59925b5
to
14cdebb
Compare
|
squashed the fixups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #23220
This fixes some windows warnings by initializing the ordinals with
-1UL. I've also changed theconst char*tostd::string_view, improved the for loops and removed strcmp and the need for pointer addition.I've added some other cleanup that removes a bunch of unused code.
The diff is best looked at with whitespace changes off -> link
What is the effect on users?
none