Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video][PVR] Info dialogs: Add support for default play action #24031

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 31, 2023

Video, PVR recordings and PVR guide dialogs offer "play" buttons. This PR adds support for default play action for these buttons, means, the button will act according to the settings value.

Runtime-tested on macOS and android, latest Kodi master.

@enen92 @phunkyfish mind taking a look at the code changes?

@ksooo ksooo added Type: Improvement non-breaking change which improves existing functionality Component: PVR Component: Video v21 Omega labels Oct 31, 2023
@ksooo ksooo added this to the Omega 21.0 Beta 2 milestone Oct 31, 2023
@ksooo ksooo force-pushed the info-dialogs-default-play-action branch from be55ffa to bc82182 Compare October 31, 2023 11:04
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something for later: instead of returning a bool in Process() consider returning a status "code" (e.g. from an enum class) so that you don't need to expose m_userCancelled

@ksooo
Copy link
Member Author

ksooo commented Oct 31, 2023

instead of returning a bool in Process() consider returning a status "code"

Idea was, that processing can be successful or not, independently of user cancelled. An enum to model all possible permutations can be tricky (later, in case more "status" come into play). Maybe the method should return a tuple in the future.

@ksooo ksooo merged commit ab478dd into xbmc:master Oct 31, 2023
2 checks passed
@ksooo ksooo deleted the info-dialogs-default-play-action branch October 31, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Component: Video Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants