Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BP][uPnP] Fix playback of files accessed with curl (ftp, http, ...) #24353

Merged
merged 1 commit into from
Dec 30, 2023
Merged

[BP][uPnP] Fix playback of files accessed with curl (ftp, http, ...) #24353

merged 1 commit into from
Dec 30, 2023

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Dec 29, 2023

Description

Backport of #23711

Motivation and context

Cleanup backport list

How has this been tested?

Master since October 17

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CrystalP
[uPnP] Fix playback from authenticated sources
a31f84b 
Credentials must be added to the URL for sources that require authentication.
@fuzzard fuzzard added this to the Nexus 20.3 milestone Dec 29, 2023
@fuzzard fuzzard closed this Dec 29, 2023
@fuzzard fuzzard reopened this Dec 29, 2023
@enen92
Copy link
Member

enen92 commented Dec 30, 2023

Jenkins build this please

@fuzzard fuzzard merged commit 5b827f1 into xbmc:Nexus Dec 30, 2023
2 checks passed
@fuzzard fuzzard deleted the bp_fix-upnp-auth-source branch December 30, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrystalP CrystalP Awaiting requested review from CrystalP

Assignees
No one assigned
Labels
Component: UPnP Type: Backport v20 Nexus
Projects
None yet
Milestone
Nexus 20.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fuzzard @enen92 @CrystalP