AESinkAudioTrack: Help broken firmwares to make kodi ignore broken delay #24597
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thexai
reviewed
Jan 28, 2024
fritsch
force-pushed
the
brokendelay
branch
2 times, most recently
from
6fc5510
to
77a825b
Compare
fritsch
added
Type: Fix
|
Let's keep that just here ... want to see if it's really needed or could be inversed ... after next beta lots of additional testers will appear ... |
thexai
reviewed
Jan 29, 2024
thexai
approved these changes
Jan 30, 2024
Kodi can supervise the sink for being stuck, which means: if you open a sink with 160 ms buffer and it does not move while eating more than twice of the buffer's audio data, it is considered a bug. Sadly - there is a whole lot of broken firmwares out there, one of the leards: Ugoos. Which is the reason I make disabled by default. That means that FireTV Cube 3rd Gen and others would need to enable this - once again - via an advanced settings. <advancedsettings> <audio> <superviseaudiodelay>true</superviseaudiodelay> <audio> </advancedsettings> Co-authored-by: thexai <58434170+thexai@users.noreply.github.com>
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kodi can supervise the sink for being stuck, which means: if you open a sink with 160 ms buffer and it does not move while eating more than twice of the buffer's audio data, it is considered a bug. Sadly - there is a whole lot of broken firmwares out there, one of the leards: Ugoos. Which is the reason I make this opt-in. That means that FireTV Cube 3rd Gen and others would need to enable this - once again - via an advanced settings.
See forum report: https://forum.kodi.tv/showthread.php?tid=376090 - I briefly informed in Slack some weeks ago and just waited to see more broken devices. Yeah, seen now the Ugoos twice ...
For now it's only the Ugoos, while I did not get other reports. The alternative to this change would be a "negative list" .... which we don't want to maintain. Sad thing is, that FireTV Cube 3rd Gen and the other boxes that need this are a bigger number.
Open for suggestions.