Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video] remove unused string #24807

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[video] remove unused string #24807

merged 1 commit into from
Mar 5, 2024

Conversation

CrystalP
Copy link
Contributor

@CrystalP CrystalP commented Mar 5, 2024

Description

Remove string 40033 unused since PR #24477.

It was a complicated condition and text, removing to simplify things for translators (question raised about it in Slack #translations-external channel)

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Stopped being used after PR xbmc#24477
@CrystalP CrystalP added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Video v21 Omega Feature: Video Versions/Extras labels Mar 5, 2024
@CrystalP CrystalP added this to the Omega 21.0 RC1 milestone Mar 5, 2024
@fuzzard fuzzard merged commit c38a7fe into xbmc:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Feature: Video Versions/Extras Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants