Enforce minimum interval between add-on repository updates #24886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yol
added
Type: Fix
lrusak
reviewed
Mar 23, 2024
|
@yol Your PR is for master, thus v22. For Omega, you need to open a backport PR heading for Omega branch. |
Repository update can fail in a way that would lead to an immediate reschedule of the update. A common reason would be a failure to update the `nextcheck` column of the `repo` table. This leads to mirror and repository servers getting constantly hammered. Since there is no reason to have a smaller update interval than an hour anyway, we just enforce this as the minimum in all regular updates. This should catch all possible errors leading to a continuous series of requests. Fixes xbmc#24829.
yol
force-pushed
the
repo-update-on-db-fail
branch
from
42a9123
to
808c783
Compare
neo1973
approved these changes
Mar 23, 2024
lrusak
approved these changes
Mar 23, 2024
14 tasks
yol
added a commit
that referenced
this pull request
Mar 24, 2024
Backport #24886 " Enforce minimum interval between add-on repository updates"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repository update can fail in a way that would lead to an immediate reschedule of the update. A common reason would be a failure to update the
nextcheckcolumn of therepotable. This leads to mirror and repository servers getting constantly hammered.Since there is no reason to have a smaller update interval than an hour anyway, we just enforce this as the minimum in all regular updates. This should catch all possible errors leading to a continuous series of requests.
Motivation and context
#24829
How has this been tested?
Manual test stepping through common cases with the debugger on my machine.
What is the effect on users?
Their broken RPi will not saturate their internet connection any more...
Screenshots (if appropriate):
Types of change
Checklist: