Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #24886 " Enforce minimum interval between add-on repository updates" #24889

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Backport #24886 " Enforce minimum interval between add-on repository updates" #24889

merged 1 commit into from
Mar 24, 2024

Conversation

yol
Copy link
Member

@yol yol commented Mar 23, 2024 •
edited

Description

Backport of #24886

Motivation and context

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@yol
Enforce minimum interval between add-on repository updates
2b77271 
Repository update can fail in a way that would lead to an
immediate reschedule of the update. A common reason would be
a failure to update the `nextcheck` column of the `repo` table.
This leads to mirror and repository servers getting constantly
hammered.

Since there is no reason to have a smaller update interval than
an hour anyway, we just enforce this as the minimum in all
regular updates. This should catch all possible errors leading
to a continuous series of requests.

Fixes xbmc#24829.
@yol yol added this to the Omega 21.0 milestone Mar 23, 2024
@yol yol requested review from lrusak, fuzzard and neo1973 March 23, 2024 20:02
@yol yol self-assigned this Mar 23, 2024
@thexai thexai added the Type: Fix non-breaking change which fixes an issue label Mar 24, 2024
@yol yol merged commit d083e13 into xbmc:Omega Mar 24, 2024
2 checks passed
@yol yol deleted the repo-update-on-db-fail-omega branch March 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neo1973 neo1973 neo1973 approved these changes

@lrusak lrusak Awaiting requested review from lrusak

@fuzzard fuzzard Awaiting requested review from fuzzard

Assignees

@yol yol

Labels
Component: Add-ons Type: Backport Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Milestone
Omega 21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yol @neo1973 @thexai