New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded or outdated _MSC_VER macro #ifs #2756
Conversation
surely some of these things really are guards for msvc and not windows in general? |
Some of them - for windows platform. They replaced with 'TARGET_WINDOWS' |
@theuni typo fixed. |
@@ -31,16 +31,11 @@ | |||
#include <fcntl.h> | |||
#include <sstream> | |||
|
|||
#ifdef _WIN32 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@Karlson2k I really hope for the day when you provide something useful like real bug fixes and such :) |
@wsoltys Cleanup is boring, but it's something that allow to avoid bugs and easier future development. |
Just be careful, on Win32 we have also the mingw gcc compiler which may make the distinction between _WIN32 and _MSC_VER. My 2cts. |
@Voyager1, thanks, right comment. MinGW-compiled code left untouched. |
need a window dev to hit the button :) |
#pragma comment(lib, "ssh.lib") | ||
#endif | ||
|
||
#ifdef TARGET_WINDOWS |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I'm generally OK, with the exception of S_ISDIR and S_ISREG (see line comment)... I'll let @wsoltys make the final decision. |
Remove unneeded or outdated _MSC_VER macro #ifs
Still wonder why linux/PlatformDefs.h contains TARGET_WINDOWS. But thats a different story |
legacy ? |
Small cleanup