Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded or outdated _MSC_VER macro #ifs #2756

Merged
merged 1 commit into from Jun 5, 2013

Conversation

Karlson2k
Copy link
Member

Small cleanup

@theuni
Copy link
Contributor

theuni commented May 16, 2013

surely some of these things really are guards for msvc and not windows in general?

@Karlson2k
Copy link
Member Author

Some of them - for windows platform. They replaced with 'TARGET_WINDOWS'
'#pragma once' is supported in GCC since at least version 3.4.

@Karlson2k
Copy link
Member Author

@theuni typo fixed.
Build tested on Ubuntu and Windows.

@@ -31,16 +31,11 @@
#include <fcntl.h>
#include <sstream>

#ifdef _WIN32

This comment was marked as spam.

This comment was marked as spam.

@wsoltys
Copy link

wsoltys commented May 17, 2013

@Karlson2k I really hope for the day when you provide something useful like real bug fixes and such :)
@theuni some of the defines where necessary for different vs versions. But since we just support nothing older than vs2010 I guess we could remove them.

@Karlson2k
Copy link
Member Author

@wsoltys Cleanup is boring, but it's something that allow to avoid bugs and easier future development.

@Voyager1
Copy link

Just be careful, on Win32 we have also the mingw gcc compiler which may make the distinction between _WIN32 and _MSC_VER. My 2cts.

@Karlson2k
Copy link
Member Author

@Voyager1, thanks, right comment. MinGW-compiled code left untouched.

@Karlson2k Karlson2k mentioned this pull request Jun 4, 2013
@davilla
Copy link
Contributor

davilla commented Jun 4, 2013

need a window dev to hit the button :)

#pragma comment(lib, "ssh.lib")
#endif

#ifdef TARGET_WINDOWS

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@Voyager1
Copy link

Voyager1 commented Jun 4, 2013

I'm generally OK, with the exception of S_ISDIR and S_ISREG (see line comment)... I'll let @wsoltys make the final decision.

wsoltys pushed a commit that referenced this pull request Jun 5, 2013
Remove unneeded or outdated _MSC_VER macro #ifs
@wsoltys wsoltys merged commit d06301e into xbmc:master Jun 5, 2013
@wsoltys
Copy link

wsoltys commented Jun 5, 2013

Still wonder why linux/PlatformDefs.h contains TARGET_WINDOWS. But thats a different story

@davilla
Copy link
Contributor

davilla commented Jun 5, 2013

legacy ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants