New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pvr: fix channel switch for addons using other stream #2757
Conversation
wasn't pOtherStream needed for mediaportal? |
Yes it is. CPVRFile is opened anyway. This returns true for SkipNext in case of live tv. Addons using stream urls open pOtherStream in addition to CPVRFile but SkipNext returns false for DVDInputStream. |
alright thanks. @margro do you have time to test this commit with mediaportal? thanks |
I confirm that this fixes the issue if use pvr.demo or pvr.iptvsimple addons. |
yeah that's what this patch is supposed to fix, so that's good, but i'd like to have someone verify that we don't break mediaportal (and i think argustv too) with this |
Should it check both? If otherstream gives something else than none then return that. Else check |
sounds reasonable. I will update. |
I've just tested master with and without this change. The MediaPortal pvr addon was not affected by the 14307 bug. |
Not good enough. You can only request next stream once. Now it's done |
thanks, updated now |
@opdenkamp as discussed on IRC, I'll put this to the backport list for Frodo. |
pvr: fix channel switch for addons using other stream
right, you were quicker than me :) |
@opdenkamp
fix trac 14307 Player stops if switch channel
pOtherStream->NextStream returns always STREAM_NONE. we need to call this on m_pFile