ActiveAE: Make ActiveAE default Audio Engine to get it tested #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for sure but shouldn't the ACTIVEAE environment variable handling be changed (inverted) as well? |
|
hmm? it's AE_ENGINE=active what's to change there? |
|
@cptspiff : That's what I meant yeah. Couldn't recall how it was implemented exactly (and was a bit to lazy to look it up ;-)) |
|
do we want to switch this monthly or in merge window? |
|
Wait two more days and push it after the E-AC3 fix of @FernetMenta is in. |
|
We want this to hit master before the next alphas are generated, right? |
|
it changes behavior and it's not a fix, thus it has to wait for merge window starting tomorrow. |
MartijnKaijser
added a commit
that referenced
this pull request
Aug 31, 2013
ActiveAE: Make ActiveAE default Audio Engine to get it tested
|
@fritsch @FernetMenta Does it still have low quality problem with video playback synced on video as discussed here FernetMenta@385b2f7#commitcomment-3779578? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last bit after all the other PRs of @FernetMenta are in.