-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win32: fix path slashes (diet version) #3408
Win32: fix path slashes (diet version) #3408
Conversation
@wsoltys As requested. jenkins build this please |
return -1; | ||
} | ||
|
||
fd = _open_osfhandle((intptr_t)((HANDLE)hFileDup), 0); | ||
if (fd == -1) | ||
{ | ||
CLog::Log(LOGERROR, "CWINFileSMB Stat: fd == -1"); | ||
CLog::Log(LOGERROR, __FUNCTION__ ": Stat: fd == -1"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Address jmarshall's points and I'm fine with it. |
@jmarshallnz FixSlashes was renamed and moved to URIUtils. Less parameters. |
jenkins build this please |
|
||
if( url.GetProtocol().Equals("file", false) ) | ||
if(url.GetProtocol() == "file") | ||
{ | ||
// file://drive[:]/path |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Looks good to me. The android build failures are not related |
Win32: fix path slashes (diet version)
This is bugfix part of larger PR #3374
Cherry-picked minimal set of commits to fix "slash"-errors.