jsonrpc: fix Files.GetDirectory returning wrong type "song" instead of "unknown" #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this should be |
|
Yes the jmarshallnz remark is what I use as hack in Yatse to cover all known cases. |
|
I agree, this sounds like a better approach. Will do the necessary changes ASAP. |
|
Updated as discussed. |
|
@jmarshallnz's button |
jmarshallnz
added a commit
that referenced
this pull request
Feb 17, 2014
jsonrpc: fix Files.GetDirectory returning wrong type "song" instead of "unknown"
MartijnKaijser
modified the milestones:
Gotham13.0-alpha12 January 2014,
Pending for inclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where JSON-RPC's Files.GetDirectory would return items with the type "song" even though they aren't songs e.g. when retrieving a list of album years using the "musicdb://years/" path. Years obviously aren't songs so the returned type should be unknown.