Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xbmc nav sound volume setting #475

Closed
wants to merge 2 commits into from

Conversation

energy6
Copy link
Contributor

@energy6 energy6 commented Oct 7, 2011

Added setting to control navigation sound volume relative to master volume in percent.
The nav sounds are overwhelm with respect to video/music. The new setting allows the user to set the nav sound volume with respect to the global volume.

@jmarshallnz
Copy link
Contributor

Sounds like we need to set a better default, rather than have yet another setting. What volume level sounds most suitable to you?

@energy6
Copy link
Contributor Author

energy6 commented Oct 9, 2011

I have set the nav sounds to 20 percent of master volume. Typically this leads to about 5 to 10 percent absolute volume.
What do you mean with "set a better default"? How do you want to change the nav sound volume? Or do you want to fix the nav sound volume at the default level?

@jmarshallnz
Copy link
Contributor

Fix the nav sound volume at a defualt level.

@jmarshallnz
Copy link
Contributor

Please re-do using a default value for percentage of actual volume so as to get rid of the UI setting.

nemphys referenced this pull request in nemphys/xbmc Mar 24, 2012
…will always be present at position 0. locking order was wrong anyway. closes #475
margro referenced this pull request in margro/xbmc Mar 24, 2012
…will always be present at position 0. locking order was wrong anyway. closes #475
@energy6
Copy link
Contributor Author

energy6 commented Jun 15, 2012

Done in 35824a0 by using an advancedsetting instead of a gui setting. New pull request follows.

@energy6 energy6 closed this Jun 15, 2012
tru pushed a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 22, 2013
HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants