Avoid incorrect disabling PVR addons #4757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2014 18:19
When addons are installed from zip they aren't added to the addon table in AddonsDB (Maybe this is the real issue here?). When PVRManager is started it checks only whether the AddonsDB has the addon, which it doesn't in this case and the addon is marked disabled in AddonsDB. The addon and PVR both work fine until the next launch of app, at which point the "No PVR Addon enabled!" dialog is thrown in the user's face. Marking the addon enabled here then adds it to the db as expected.
|
@opdenkamp for review @jmarshallnz for review. Should we be injecting zip sourced addons into the db instead? I'm not sure how this might effect installing something from zip that's also in a repo. |
|
Closing in favor of #4761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As topic