Avoid incorrect disabling PVR addons (Alternate)

[t-nelson]

Alternate to #4757.

[t-nelson]

Heh...WTF is github up to now...

[t-nelson]

Ah, wrong branch. Sorry for the noise.

ie. Fixed now.

[opdenkamp]

did you test this with a clean installation (removed ~/.xbmc before running)?
PVR add-ons need to be configured, or disabled by default when not configured.

[t-nelson]

@opdenkamp Nope, top two should address.

I'll do some squashing before push.

[t-nelson]

jenkins build this please

[t-nelson]

@opdenkamp Did you give this one the OK on IRC? I can't remember... :/

[opdenkamp]

if you tested those cases i mentioned, and tried installing a new add-on via a zip which gets disabled, then +1

[AlwinEsch]

Has also add your correction to my ADSP Pull request #4402 which use the same way to load the add-ons, thank a lot t-nelson.

[stefansaraev]

@t-nelson this breaks "reset pvr database". reverting last commit fixes it.

[t-nelson]

"Breaks" how? I'm pretty sure I've used the reset thing since this went in and the database seemed pretty empty.

[stefansaraev]

"breaks" like pvr plugin disabled, pvr database wiped, pvr plugin NOT (re)enabled.

[t-nelson]

OK. I'll look into it on Monday.

[t-nelson]

@opdenkamp I guess we need to clear m_clientMap from CPVRClients. Is there anything else we should/shouldn't consider wiping from memory on db reset?

[opdenkamp]

the add-on shouldn't be automatically re-enabled when you clear the database. if it did that before, then that was a bug. it should only clear the pvr tables, not do anything with the add-on db

[stefansaraev]

k then, let me explain it again, in depth..

my use case: add some (iptv) channels to vdr backend.

before this pr, 2 simple steps to reset and enjoy live tv:

• do stuff on vdr's channels.conf, restart backend
• settings -> live tv -> reset pvr database
• main menu -> live tv. new channels there, all works as expected

after this pr, 4 not-so-simple steps, including an annoying "hey I am not runing" message, or "what where did TV go?":

• do stuff on vdr's channels.conf, restart backend
• settings -> live tv -> reset pvr database
• main menu -> tv. meh. there is no tv entry in main menu at all. as there is no single pvr client addon runing

next:

• go settings -> addons -> disabled addons -> vdr vnsi pvr client -> enable (because it is disabled!)
• main menu -> tv - all good. I can enjoy xbmc ;)

or:

• settings -> live tv > disable -> enable -> got message "no pvr clients enabled" -> ok -> list shows up -> vnsi -> enable
• main menu -> tv ...

this is a change in behaviour. the one before this pr is what I am familiar with, and almost everyone I know that use xbmc + pvr.

the add-on shouldn't be automatically re-enabled when you clear the database. if it did that before,
then that was a bug. it should only clear the pvr tables, not do anything with the add-on db

so what do you mean here, excuse my ignorance but I dont understand:

1. disabling all pvr clients on pvr database reset is a normal thing. they should not be re-enabled. if that happened before, that's a bug
   or
2. people are NOT allowed to reset the pvr database while pvr manager is runing, they are expected to go live tv -> disable, then reset, then re-enable?

if 1. then see above the change-in-behaviour note, because that's what most users (at least those I know personaly, including me) are familiar with
if 2. the "reset pvr database" option should be greyed out if pvr manager is runing. in general that's ok and I feel it acceptable. I can prepare a patch and send PR if you think that's what "reset pvr database" is intended to do.