[videodb] don't set the playcount on scan if missing episode/season numbers #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n when adding new episodes if the new episode doesn't have a defined episode and season number. fixes xbmc#15234
|
Looks ok. |
|
jenkins build this please |
jmarshallnz
added a commit
that referenced
this pull request
May 25, 2014
[videodb] don't set the playcount on scan if missing episode/season numbers
|
As I suspected, it's exactly there to deal with duplicates: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new episodes on scan we lookup to see if we have a previously matching episode/season for this show with an existing playcount in order (I'm guessing?) to preserve the playcount for duplicates.
This causes issues if the episode/season numbers are not specified, as any previous episode matches.
I'm guessing that we pretty much don't support very well the latter case (i.e. where aired date is specified but season/episode aren't). Also, I don't really see the point of this codeblock - it only matches existing episodes that match season/episode number but are duplicates. Seems to me that we should just be detecting the dupes instead?
Fixes #15234.
@vdrfan, @Montellese please take a look.