change: Remove dropped "audiohost" from advancedsettings #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should drop those other occurences too. |
|
looks fine. jenkins build this please |
According to IRC talk XMLUtils::GetString(pElement, "audiohost", m_audioHost); And remove remaining references to m_audioHost So we dont end up with unreachable code
un1versal
changed the title
fritsch
added a commit
that referenced
this pull request
Jun 14, 2014
change: Remove dropped "audiohost" from advancedsettings
|
@UniversaI: Please update the wiki accordingly if you did not do that already. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to IRC talk
XMLUtils::GetString(pElement, "audiohost", m_audioHost);
Is left over and gone.
also remove references in
xbmc/xbmc/settings/AdvancedSettings.h
Line 180 in cff55a4
and
xbmc/xbmc/settings/AdvancedSettings.cpp
Line 130 in 6afb499
tbh I bit off more than I can chew but at least its here for reference if nothing else right?
@fritsch