[AE/osxsink] - fix wrong samplerate selection #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt - fixes some formats with optical which don't support 96000Hz
|
Looks fine. jenkins build this please |
Memphiz
added a commit
that referenced
this pull request
Jun 29, 2014
[AE/osxsink] - fix wrong samplerate selection
Memphiz
added a commit
that referenced
this pull request
Jul 8, 2014
[AE/osxsink] - fix wrong samplerate selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the selection of streamFormats in the osx sink by taking the samplerate into account.
The problem was brought up from users with optical links to their amps. OSX assumes that each optical amp allows sample rates up to 96000 Hz. As it seems most amps don't support sample rates higher then 48000 Hz. Our current streamFormat scoring algorithm didn't prefer any samplerates if they don't match exactly. In the example the user wanted to play a mono audiostream with 22050Hz. Our scorealgorithm then picked 96000Hz because it was the first format in the list.
With this PR the samplerates are choosen according to this order:
Of course those users will have issues when trying to play 96000 Hz content - but there is nothing we can do about it (in that case they need to use the "fixed" preset).
Also added test cases for scoreStream.
@jmarshallnz for review