Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [droid] crash if an app is favourited, then uninstalled from system #5095

Merged
merged 1 commit into from
Aug 1, 2014

Conversation

koying
Copy link
Contributor

@koying koying commented Jul 24, 2014

/cc @t-nelson

@Montellese
Copy link
Member

Looks sane.

@MartijnKaijser MartijnKaijser added this to the Pending for inclusion milestone Jul 24, 2014
int numPackages = packageList.size();
for (int i = 0; i < numPackages; i++)
CSingleLock lock(m_applicationsMutex);
if (m_applications.size() == 0)

This comment was marked as spam.

@koying
Copy link
Contributor Author

koying commented Jul 25, 2014

updated

@MartijnKaijser
Copy link
Member

Also fixes crash when opening programs (add-ons) in the Amber skin.

@MartijnKaijser
Copy link
Member

jenkins build this please

jmarshallnz added a commit that referenced this pull request Aug 1, 2014
FIX: [droid] crash if an app is favourited, then uninstalled from system
@jmarshallnz jmarshallnz merged commit 9e05ec2 into xbmc:master Aug 1, 2014
@jmarshallnz jmarshallnz removed the Gotham label Aug 1, 2014
jmarshallnz added a commit to jmarshallnz/xbmc that referenced this pull request Aug 1, 2014
FIX: [droid] crash if an app is favourited, then uninstalled from system
Conflicts:
	xbmc/filesystem/AndroidAppDirectory.cpp
jmarshallnz added a commit to jmarshallnz/xbmc that referenced this pull request Aug 2, 2014
FIX: [droid] crash if an app is favourited, then uninstalled from system
Conflicts:
	xbmc/filesystem/AndroidAppDirectory.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants