Removecrystalhd

[fritsch]

This was discussed in the internal forum for years now and was timelined for helix. CrystalHD is not supported anymore and no dev is testing / running it.

As discussed and acked by @davilla the original author - I tried to pull out everything crystalhd related.

If and only if really someone wants to get back crystalhd support, we should use the ffmpeg hw accel for this, which is not on my list anywhere.

[fritsch]

jenkins build this please

[fritsch]

I will squash down once i get okay from the team and give those people that use it time to volunteer to maintain crystalhd upstream.

[MartijnKaijser]

@davilla
care to review if anything missed? thx

[fritsch]

Don't merge this please - just keep it open.

@samnazarko tweeted me to become maintainer of crystalhd and migrating it to an ffmpeg hwaccel and seeing to get it optimized by adjusting it to the render / buffering changes we got through the years.

So let's wait - Helix won't be released tomorrow.

[t-nelson]

Just rip it out of xbmc now. Its current state is broken. If a new
maintainer shows up they can PR it back in. There's no point in keeping
broken, unmaintained code around at the promise of someone new to pick it
up.

[fritsch]

Okay. I hand over this PR to whoever wants it. I squashed the changes. Presquash code for easier review is here: https://github.com/fritsch/xbmc/commits/crystalremtmp

[t-nelson]

@davilla any other special cases that might be hiding?

I hear there's some debate about @fritsch's involvement with openelec and this PR. My previous comment is my own and formed without any outside discussion. I have no involvement with openelec. I've never even downloaded it. Broken, abandoned code simply has no place in an actively developed project.

[davilla]

rip it.

[t-nelson]

@FernetMenta your honors?

[FernetMenta]

Would be my pleasure to press the button here but I am on vacation this merge window. Not sure if get a chance to get online during this time.

[MartijnKaijser]

jenkins build this please

[MajorMeat]

So many people have an ATV 1, would be nice to continue the support for a working CrystalHD. No one is willing to rescue this for all of us ATV 1 users...

[da-anda]

what's the issue - just keep using your current XBMC version - done. There is always a point when old software/hardware becomes obsolete - just like we don't support WindowsXP, Android 2.x and older Linux distris anymore. And don't blame us for not wanting to support unmaintained code - blame upstream.