Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X11] Add support for EGL/GLESv2 when using X11 #5113

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

Phaeodaria
Copy link
Contributor

This adds EGL/GLESv2 support to the new X11 backend which doesn't use SDL anymore.

@@ -20,7 +20,7 @@

#include "system.h"

#ifdef HAS_GLX
#if defined(HAS_GLX) || defined(HAS_EGL)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@FernetMenta
Copy link
Contributor

I am ok with this. We have discussed on irc that windowing requires a big refactoring round in order to get this clean but this is work for a future pr.

@Phaeodaria
Copy link
Contributor Author

jenkins build this please

1 similar comment
@topfs2
Copy link
Contributor

topfs2 commented Aug 22, 2014

jenkins build this please

@topfs2 topfs2 modified the milestones: Pending for inclusion, Helix 14.0-alpha4 Aug 22, 2014
@FernetMenta
Copy link
Contributor

@Phaeodaria please rebase

@topfs2 @jmarshallnz could you please approve this. GLX is dying, EGL is the future. VAAPI will provide interoperability with EGL so this will become default soon.

@topfs2
Copy link
Contributor

topfs2 commented Aug 31, 2014

Im ok with it if it doesn't cause regressions

@topfs2
Copy link
Contributor

topfs2 commented Aug 31, 2014

What I mean is that the old behaviour is still left and is the default no?

@FernetMenta
Copy link
Contributor

The old behavior should be untouched by this PR and is still default on Linux X11.

@topfs2 topfs2 added Abandoned and removed Abandoned labels Sep 1, 2014
@topfs2
Copy link
Contributor

topfs2 commented Sep 1, 2014

jenkins build this please

@Phaeodaria Phaeodaria force-pushed the egl-x11-pr branch 3 times, most recently from fd7328a to 7649e96 Compare September 4, 2014 16:41
@Phaeodaria
Copy link
Contributor Author

jenkins build this please

@Phaeodaria
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor

OSX errors unrelated (time outs), they passed in the last run.
@Phaeodaria your button

Phaeodaria added a commit that referenced this pull request Sep 4, 2014
[X11] Add support for EGL/GLESv2 when using X11
@Phaeodaria Phaeodaria merged commit a44dda1 into xbmc:master Sep 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants