Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lirc] preventing multiple connections to the lirc socket ... #5268

Merged
merged 1 commit into from
Aug 24, 2014

Conversation

phoefler
Copy link
Contributor

Details to this PR already explained in forum:
http://forum.xbmc.org/showthread.php?tid=202592

This fix should prevent that Kodi connects to the same socket multiple times if XBMC.LIRC.Start is called multiple times.

@FernetMenta
Copy link
Contributor

looks sane
jenkins build this please

@FernetMenta
Copy link
Contributor

jenkins build this please

@phoefler
Copy link
Contributor Author

Seems like jenkins doesn't like me :(

@fritsch
Copy link
Member

fritsch commented Aug 23, 2014

jenkins build this please

@phoefler
Copy link
Contributor Author

Is jenkins on vacation? ;-)
Only works from collaborators, isn't it?
Let's try anyway:
jenkins build this please

@fritsch
Copy link
Member

fritsch commented Aug 23, 2014

You cannot trigger it, but we should have been able to do so - we called for help :-)

in the meantime: jenkins build this please

@topfs2
Copy link
Contributor

topfs2 commented Aug 24, 2014

Could you open a separate PR for Gotham?
For helix it can go in as soon as Jenkins is happy.

@FernetMenta
Copy link
Contributor

@topfs2 did anything change in regard to Gotham fixes. We were instructed not to send separate PRs to Gotham branch if the change does apply. RMs cherry-picked fixes tagged with Gotham

@wsnipex
Copy link
Member

wsnipex commented Aug 24, 2014

jenkins build this please

@fritsch
Copy link
Member

fritsch commented Aug 24, 2014

@FernetMenta: That policy has changed, check the mails of @MartijnKaijser - separate PRs are a must for 13.3

@Gotham
As for the 13.3 it was requested to please create PRs against Gotham branches for the fixes you are confident of that will work for the 13.3.
...
So create a PR for Gotham branch and add the label "Gotham" to it (and also make sure you mention it in the PR).

topfs2 added a commit that referenced this pull request Aug 24, 2014
[lirc] preventing multiple connections to the lirc socket ...
@topfs2 topfs2 merged commit 3bb9544 into xbmc:master Aug 24, 2014
@topfs2
Copy link
Contributor

topfs2 commented Aug 24, 2014

Since jenkins clearly doesn't want to play ball and the code changes are minimal I'm merging anyways :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants